fix: Docs examples #9190
Merged
fix: Docs examples #9190
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
reidbarber
approved these changes
Nov 17, 2025
|
Build successful! 🎉 |
devongovett
reviewed
Nov 21, 2025
| gridTemplateColumns: '25px 24px 24px 25px 24px', | ||
| gridTemplateRows: '25px 24px 24px 25px 24px' | ||
| gridTemplateColumns: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))', | ||
| gridTemplateRows: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))' |
Member
There was a problem hiding this comment.
Can't we use an array of numbers here and the style macro will do this automatically?
Suggested change
| gridTemplateRows: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))' | |
| gridTemplateRows: [25, 24, 24, 25, 24] |
devongovett
approved these changes
Nov 21, 2025
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
I'll follow up on my comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Fixed locales not working, it involves including every locale though, which defeats the purpose of optimising, but it's the only way to make that one example work
Fixed size of placement control for popover in RAC docs, it takes up a lot of room in mobile though, do we want some sort of container query instead which turns it into a Select instead?
Fixed making DateField scroll, it already was "fixed" via width: content, but this seems more complete and useful.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: